Upgrade sass to version 1.54.0 #68380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
t-hamano
added
[Type] Enhancement
t-hamano
requested review from
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Dec 30, 2024
|
Flaky tests detected in 34fcc71. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12542942236
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while working on #68282
What?
This PR updates the sass version from
1.50.1to1.54.0in the Gutenberg project and scripts package.Why?
In #68282, I proposed adding the missing
reduce-motionmixin. However, I found that thecomponentspackage uses the following standard pattern instead of the mixin:So I tried to introduce a similar standard pattern to packages other than the
componentspackage, but sass, which is used in Gutenberg and scripts, does not support this pattern, so the following error occurs during build.How?
To make such CSS patterns available, upgrade sass version to
1.54.0, which supports the new media query syntax.Actually, we can upgrade up to
1.77.6. We cannot upgrade to1.77.7or higher, because1.77.7added a deprecation related to nested rules.dart-sass CHANGELOG
Testing Instructions
Add the following style to any package:
Run
npm run build:packageswp-scripts
Add the above style to any stylesheet and run
../node_modules/.bin/wp-scripts build