Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fontSizePicker header deisgn changes #68383

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

fontSizePicker header deisgn changes #68383

wants to merge 1 commit into from

Conversation

rinkalpagdar
Copy link
Contributor

Fixes #68344

Screenshots or screencast

fontsizepicker-design

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 30, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: rinkalpagdar <[email protected]>
Co-authored-by: yogeshbhutkar <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: snehapatil2001 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@yogeshbhutkar
Copy link
Contributor

Thanks for the PR ✨

As highlighted in this comment, the height rule is intentionally applied to maintain consistency with the layout. Opened an alternate PR (with a different approach) here.

@t-hamano t-hamano mentioned this pull request Jan 2, 2025
Open
6 tasks
@t-hamano
Copy link
Contributor

t-hamano commented Jan 2, 2025

There are two approaches to solving this problem:

It might be worth discussing which approach to take in more detail in #68344.

@t-hamano t-hamano mentioned this pull request Jan 2, 2025
Open
@t-hamano t-hamano added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Typography Font and typography-related issues and PRs [Type] Bug An existing feature does not function as intended labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
[Feature] Typography Font and typography-related issues and PRs Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Site Editor Layout Breaks When changing existing names of Font Sizes with Long Names in theme.json
3 participants
@rinkalpagdar @yogeshbhutkar @t-hamano