Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Enable Comments" button from Post Comments Form block #68384

Open
wants to merge 20 commits into
base: trunk
Choose a base branch
from

Conversation

karthick-murugan
Copy link
Contributor

@karthick-murugan karthick-murugan commented Dec 30, 2024

What?

Fixes #54019

This PR removes the "Enable Comments" button from the Post Comments Form block in scenarios where comments are disabled or unsupported for the current post type or post.

Why?

The button created confusion in the site editor when it appeared in contexts where enabling comments was not actionable. Removing it simplifies the UI and ensures users are only presented with relevant information.

How?

The "Enable Comments" button has been removed, and warnings are displayed to inform users when comments are disabled or unsupported. The placeholder block consistently shows the status of comments without unnecessary UI elements.

Testing Instructions

  1. Enable TT3 theme.
  2. Open the site editor and add a template containing the Post Comments Form block.
  3. Test with comments enabled and disabled globally, and for specific post types.
  4. Confirm that the button is no longer present, and warnings appear as expected when comments are disabled.

Screenshots or screencast

Before

comments_button_enabled

After

enable_comments_disabled

Copy link

github-actions bot commented Dec 30, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @nudgeD.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: nudgeD.

Co-authored-by: karthick-murugan <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: SaxonF <[email protected]>
Co-authored-by: draganescu <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@karthick-murugan karthick-murugan changed the title Remove/enable comments button Remove "Enable Comments" button from Post Comments Form block Dec 30, 2024
@carolinan
Copy link
Contributor

Hi
I am confused about the intention of this change.
The pull request description makes it sound like it was intended to remove it only under certain conditions? Depending on the support on the custom post type.
But that does not match the issue? And the code change completely removes the button.

@carolinan carolinan added [Block] Post Comments Form Affects the Comments Form Block [Type] Bug An existing feature does not function as intended labels Jan 2, 2025
@karthick-murugan
Copy link
Contributor Author

@carolinan - I believe the description may have caused some unintended confusion, so I updated the description. The PR is specifically intended to remove the "Enable Comments" button from the Post Comments Form block. If there are any logic changes or additional adjustments required, please let me know.

Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @carolinan already said, we should not remove this button unless the post type doesn't support comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Comments Form Affects the Comments Form Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments cannot be enabled from site editor on a page
3 participants