-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "Enable Comments" button from Post Comments Form block #68384
base: trunk
Are you sure you want to change the base?
Remove "Enable Comments" button from Post Comments Form block #68384
Conversation
This reverts commit 63f81c1.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @nudgeD. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Hi |
@carolinan - I believe the description may have caused some unintended confusion, so I updated the description. The PR is specifically intended to remove the "Enable Comments" button from the Post Comments Form block. If there are any logic changes or additional adjustments required, please let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @carolinan already said, we should not remove this button unless the post type doesn't support comments
What?
Fixes #54019
This PR removes the "Enable Comments" button from the Post Comments Form block in scenarios where comments are disabled or unsupported for the current post type or post.
Why?
The button created confusion in the site editor when it appeared in contexts where enabling comments was not actionable. Removing it simplifies the UI and ensures users are only presented with relevant information.
How?
The "Enable Comments" button has been removed, and warnings are displayed to inform users when comments are disabled or unsupported. The placeholder block consistently shows the status of comments without unnecessary UI elements.
Testing Instructions
Screenshots or screencast
Before
After