-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Block Library]: A11y - Add and Update missing reduce-motion
mixing
#68413
[Block Library]: A11y - Add and Update missing reduce-motion
mixing
#68413
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
reduce-motion
mixingreduce-motion
mixing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
- Isn't this PR only for the
block-library
package? Theblock-editor
package is being worked on in [Block Editor]: A11y - Add and Update missing reduce-motion mixing #68417, right? - The following PRs are included in this PR, so can we close them?
@Mayank-Tripathi32 I noticed that #68315 about the As for the |
Part of #68282
What?
Refactors animation and transition styles to use @media not (prefers-reduced-motion) for improved accessibility, ensuring a better experience for users who prefer reduced motion.
Why?
Currently, many parts of the codebase do not consider users' motion preferences, which may not be ideal for those with reduced motion settings. This PR addresses and fixes that issue.
How?
This PR updates the old reduce-motion mixin implementation and addresses missing cases to adopt the new approach outlined in the parent issue.
Standard adopted from @wordpress/components
Navigation Block
Testing Instructions
Open the Block Editor
Add a Navigation Block
Test Normal Behavior
Test with Reduced Motion Preference
Disable Reduced Motion Preference
Screencast
(its hard to notice the difference, because its only 0.1s.)
Test-navigation-motion.mp4
Test-navigation-fr.mp4
Social Block
Testing Instructions
Open the Block Editor
Add a Social Block
Test Normal Behavior
Test with Reduced Motion Preference
Disable Reduced Motion Preference
Screencast
Socal.block.mp4
Gallery Block
Considerations
The code is largely deprecated, so I'm unsure if this PR is necessary, especially since we might be cleaning up the CSS soon.
FreeForm Block (classic editor)
Screencast
freeform.test.mp4
Image Block
Open the Block Editor
Add an Image Block
Enable the Lightbox Feature
Test Normal Behavior
Test with Reduced Motion Preference
Disable Reduced Motion Preference