Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Standardize reduced motion handling using media queries #68424

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

himanshupathak95
Copy link
Contributor

@himanshupathak95 himanshupathak95 commented Dec 31, 2024

Part of: #68282

What?

Replace all instances of the reduce-motion mixin with standardized @media not (prefers-reduced-motion) media queries across the editor package components to improve code consistency and maintainability.

Testing Instructions

Test Document Bar and Tools:

  • Open the editor
  • Hover over the document bar buttons
  • Click the inserter toggle (+ button)
  • Verify smooth transitions with motion-enabled
  • Verify instant changes with reduced motion enabled

Test Publish Panel:

  • Click the publish/update button
  • Observe the panel slide-in
  • Verify smooth animation with motion-enabled
  • Verify instant appearance with reduced motion enabled

Screencast

Screen.Recording.2025-01-01.at.15.35.12.mov
Screen.Recording.2025-01-01.at.15.36.33.mov
Screen.Recording.2025-01-01.at.15.38.17.mov

@himanshupathak95 himanshupathak95 marked this pull request as ready for review January 1, 2025 12:03
Copy link

github-actions bot commented Jan 1, 2025

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Jan 1, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: himanshupathak95 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant