Changed publish word to publish date

[benazeer-ben]

What?

Fixes: #41319

Why?

The word "Publish" is not descriptive as to what the option modifies. It should give the user a clear indication of what will be changed or modified.

How?

Changed publish word to publish date in sidebar and also in modal.

Testing Instructions

1. Open a post or page.
2. Publish the page.
3. Check publish details in sidebar and verify.

Screenshots or screencast

Before	After

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @deborah86.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: deborah86.

Co-authored-by: benazeer-ben <[email protected]>
Co-authored-by: skorasaurus <[email protected]>
Co-authored-by: afercia <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: kristastevens <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[skorasaurus]

Thanks for the pull request; this has been a minor pet peeve of mine and has confused some of my coworkers who only work with gutenberg as a content editor.

As mentioned in the original issue #41319 - using publish multiple times is confusing. I support this change.

Notably, the nearby aria-label for both instance states 'change publish date'

gutenberg/packages/editor/src/components/post-schedule/panel.js

Line 48 in e5dca54

'aria-label': __( 'Change publish date' ),

&

gutenberg/packages/editor/src/components/post-schedule/panel.js

Line 77 in e5dca54

aria-label={ sprintf(

cc'ing @afercia because I think you were working (and advocating for) for issues like these a while back.

I fear that this PR will end up being buried because it's not made by a core contributor :/

[afercia]

Personally I'd be in favor of the proposed change because as mentioned in the related issue 'Publish' 1) it's unclear 2) there's a clear inconsistency between verbs and names.

Some care should be taken with translations that may provide longer strings. For example, the correct translation in Italian would be 'Data di pubblicazione' which would go in two lines. Same would happen with many other languages. At the very least the vertical alignment should take into account the increased height when the text wraps in two lines. Screenshot:

[t-hamano]

I think this PR is also related to #63342.

One concern is mentioned in this comment:

The default date/time value when creating a new post is Immediately, which is likely the reason why this visual label was changed to Publish. The new wording should complement well with Immediately.

In other words, is the following display acceptable?

Post sidebar:

Pre-publish panel (If this panel is expected to improve as well):

[afercia]

Related: I think I've mentioned in another issue or PR (couldn't find it any longer) that the term Immediately should be reconsidered, also because in the publish date popover it's called Now. Which is inconsistent and likely a good way to confuse users. Screenshot: