Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Navigation open submenu on click unavailable for page-list #68462

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

AhmarZaidi
Copy link
Contributor

This PR fixes #65513

What?

The solution automatically resets the openSubmenusOnClick attribute to its default state (false) when the last core/navigation-submenu block is removed from a core/navigation block.

Why?

This change addresses an issue where the "open on click" setting remains active even when no submenus are present. By resetting the attribute, we ensure the block's configuration reflects its current state accurately.

How?

The implementation uses the useEffect hook to monitor changes in the innerBlocks of the core/navigation block. When the inner block list is not empty and no core/navigation-submenu blocks are present, the openSubmenusOnClick attribute is set to false.

Testing Instructions

  1. Open a post or page in the editor.
  2. Insert a core/navigation block.
  3. Add a core/navigation-submenu block within it.
  4. Enable the "open on click" setting.
  5. Remove the core/navigation-submenu block.
  6. Verify that the "open on click" setting is reset to false by switching to Code Editor.

Testing Instructions for Keyboard

N/A

Screenshots or screencast

Screen.Recording.2025-01-02.at.5.30.06.PM.mov

Copy link

github-actions bot commented Jan 2, 2025

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Jan 2, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: AhmarZaidi <[email protected]>
Co-authored-by: djcowan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@AhmarZaidi AhmarZaidi marked this pull request as draft January 2, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation open submenu on click unavailable for page-list
1 participant