Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Link: Enable all non-interactive formats #68737

Merged

Conversation

shimotmk
Copy link
Contributor

What?

Similar #67585 #67559

Why?

Allow customization from plugins, allowing for a variety of design expressions !

How?

Allows consumers to register custom formats that can be used with navigation blocks.

Testing Instructions

  1. Open a post or page.
  2. Insert a navigation block.
  3. Confirm that all non-interactive formats are visible for the Home link.

Testing Instructions for Keyboard

Screenshots or screencast

Before After
before after

Copy link

github-actions bot commented Jan 17, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Block] Home Link Affects the Home Link Block labels Jan 17, 2025
@Mamaduka Mamaduka self-requested a review January 17, 2025 09:24
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @shimotmk!

The change makes sense. Let's aim for consistency when possible.

@Mamaduka Mamaduka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 17, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 17, 2025
@Mamaduka Mamaduka merged commit c2d2d69 into WordPress:trunk Jan 17, 2025
72 of 75 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.2 milestone Jan 17, 2025
@shimotmk shimotmk deleted the update/navigation-items-allow-all-formats branch January 17, 2025 11:19
@shimotmk
Copy link
Contributor Author

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Home Link Affects the Home Link Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants