List view: Rename block on double-click #68744
Open
+113
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanfra
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +59 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Thanks for looking 🙌 This is an alternative PR, with the key difference being that it restricts renaming to list view items that actually have the option to be renamed. It's also using the latest changes in the rename component. That said, we can absolutely move forward with the other PR if preferred. |
|
Don't have a strong opinion, but I guess we can continue working on the feature here. Why?
Let's make sure we give @rinkalpagdar props when this is merged. |
Mamaduka
reviewed
Jan 17, 2025
packages/block-editor/src/components/list-view/block-select-button.js
Outdated
Show resolved
Hide resolved
|
Thanks, George! Sounds good to me 🫡 |
|
I want to confirm that the change to what happens when you use the Enter key was removed? Since this affects how you add new paragraphs. |
|
@carolinan, yes, I believe it was removed in 38c3927. The PR should focus on updating the "double-click" behavior, and any other "shortcuts" for renaming should be discussed separately. |
|
Hi @carolinan, yes, that was removed so we can revisit and discuss it when deciding on shortcuts and keyboard actions. However, it wasn’t affecting how new paragraphs were added. Pressing “Enter” to rename only worked after a second click in the list view to select the block itself. You can check in trunk that after selecting the block with two clicks, pressing “Enter” doesn’t add a new paragraph. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #66829
Adding the functionality to rename blocks on double click for the list view.
Why?
Renaming a block is currently a bit tricky, requiring several clicks and lacking a keyboard shortcut.
How?
Including the rename modal on double click and adding the ability to rename blocks on double-click.
Testing Instructions
Screenshots or screencast
rename-list-view.mp4