-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try a block-based theme, again #624
Conversation
a948bf8
to
5020959
Compare
I like the concept of the proposed placeholders. Good information about what patterns are and a CTA for creating them. @rmartinezduque, any thoughts?
Search would be nice if it's not too difficult. As an aside, I found that is impossible to search by the pattern author. If there is any way to fix this, that would be awesome. |
These will automatically be converted to the correct paths by the navigation block filter. Using relative links also triggers the page lookup, so that `current-menu-item` is applied correctly.
I agree! If we have some flexibility, I'd only suggest making some minor edits for readability and clarity:
Regarding the "Create a pattern" copy, I'm not entirely clear what we want to convey or communicate with the following (or, in other words, what's the benefit behind it):
Would you mind sharing some more context? Thanks! |
Honestly I chopped this one up from this "Submit your Block Pattern" docs article. The benefit to theme authors is that they don't need to ship the pattern code in a theme (like this in Twenty Twenty-Four), but instead could just list off some pattern names that are on the directory. So a theme author could create one "Fancy Call to Action" pattern and use it in multiple themes, without duplicating that code. |
Thanks for clarifying, @ryelle. In that case, I'd suggest something along these lines for more clarity:
I also noticed that the header description could be made slightly concise by eliminating the repetition of "designed":
|
Co-authored-by: rmartinezduque <[email protected]>
On Safari/Chrome, the iframe's readystate can be complete even when it's not, which shorts out this onload resizing.
- Update search placeholder - Update single pattern header font - Add a min-width to the copy button - Use filled/empty stars for favorites - Use a smaller border radius for pattern preview - Update footer Fixes #633
Status update: I've addressed the feedback from @jasmussen in #633, and those changes have been deployed. I'm waiting on a mockup of the single pattern view & grid view (removing the masonry). I think I'm going to move to merge this PR tomorrow - it won't change anything on production, but then we can move those remaining tasks out into individual issues. |
See #518. This uses the patterns from Showcase & Developer, along with the blocks written for those sites like Query Filters, to quickly mock up a Pattern Directory using the wporg-parent-2021 theme. This is roughly referencing this figma design, though there are no plans to add the bundle feature now. Similarly, I did not add the horizontal scroll areas (ex, "more by [author]").
In the process I also fixed the pattern creator's compat issue with Gutenberg #623.
Still left to do:
<!-- wp:wporg/pattern-preview /-->
directly)wp_nav_menu_objects
due to using a page on front? maybe need to switch to blog to build header menu? Error in ja.w.org, in es.w.org it just returns the wrong URL for News.Out of scope for the new theme
UX Questions
Should we have some copy in the footer? I dropped some content from docs that seemed helpful, but it's definitely placeholder :)Answered below.Screenshots
The homepage, showing 12 "featured" patterns by popularity (this doesn't work on Rosetta sites, because the English variants are more popular than the locale ones). The link at the end links off to the archive, of all patterns by most recent.
Other "grid" pages, which all use the same layout. My patterns is broken, see the "todo" notes.
A pattern by the current user, with action buttons in the footer. This is not using the dropdown mostly to avoid building a new block for it, so hopefully we can continue to avoid that :)