Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update order of the sub navigation items #703

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

StevenDufresne
Copy link
Collaborator

Following this commit on learn and the theme directory, this PR updates the "my" links to occur after the separator.

Screenshots

Current Proposed Logged out Proposed Logged in
Screenshot 2024-07-15 at 2 29 25 PM Screenshot 2024-07-15 at 2 27 47 PM Screenshot 2024-07-15 at 2 27 34 PM

Copy link
Contributor

@ryelle ryelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some lint issues, but otherwise this looks good— it matches design's proposal here: WordPress/wporg-mu-plugins#621.

@StevenDufresne StevenDufresne merged commit 9f5384c into trunk Jul 16, 2024
3 checks passed
@StevenDufresne StevenDufresne deleted the fix/update-navigation-to-match-themes branch July 16, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants