Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT1 Blocks: Migrate Pullquote block styles #225

Merged
merged 6 commits into from
Aug 19, 2021
Merged

Conversation

danieldudzic
Copy link
Collaborator

@danieldudzic danieldudzic commented Feb 25, 2021

Part of #82
Closes: #126

Dependencies:

PR: WordPress/gutenberg#29361

@kjellr
Copy link
Collaborator

kjellr commented Aug 19, 2021

I refreshed this PR today. I removed the font size stuff since it still hasn't landed in Gutenberg, and was making the citation line really huge. Here's the current state:

TT1 Blocks Twenty Twenty-One
Screen Shot 2021-08-19 at 11 51 18 AM Screen Shot 2021-08-19 at 11 51 13 AM

As you can see, we're missing the ability to set the border to appear on just the top and bottom. I've opened a Gutenberg issue here to discuss that: WordPress/gutenberg#34179

@pbking
Copy link
Collaborator

pbking commented Aug 19, 2021

we're missing the ability to set the border to appear on just the top and bottom.

If we set the value of border.style to "solid none" that appropriately renders the borders like TwentyTwenyOne's:

And while the user wouldn't be able to reproduce the effect with the editor they can still switch away to any of the other options just fine.

image

I agree that the work in Gutenberg is still needed but I don't believe '"solid none"' is wrong. What do you think?

@pbking
Copy link
Collaborator

pbking commented Aug 19, 2021

Add in a dash of typography styles and it's not a far throw from the original:
image

Copy link
Collaborator

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works for me! Thanks, @pbking!

@kjellr kjellr merged commit cd51486 into master Aug 19, 2021
@kjellr kjellr deleted the migrate/pullquote branch August 19, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TT1 Blocks: Pullquote Block: Migrate CSS to theme.json
3 participants