Twenty Twenty One Blocks: Migrate Paragraph Block styles #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
reviewed
Nov 25, 2020
MaggieCabrera
commented
Nov 25, 2020
MaggieCabrera
changed the title
scruffian
reviewed
Nov 26, 2020
|
I think it would be good to remove the code that needs to live in GB so we can merge the other changes... |
kjellr
reviewed
Nov 30, 2020
kjellr
reviewed
Dec 9, 2020
| .has-huge-font-size, | ||
| .has-gigantic-font-size { | ||
| font-weight: var(--wp--custom--font-weight-light); | ||
| } |
There was a problem hiding this comment.
This was kind of a weird hack the theme did — we wanted to make sure that the largest font size presets all used a light weight. Not the best solution. 😅
It's fine to remove this, but we should try to make sure the h1 begins using the light font weight preset once it's available to that block.
kjellr
reviewed
Dec 9, 2020
kjellr
approved these changes
Dec 9, 2020
Co-authored-by: Kjell Reigstad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added styles for
strong,b, and other tags that affect the paragraph block (and others, of course):https://github.com/WordPress/twentytwentyone/blob/trunk/assets/sass/04-elements/misc.scss
Related #91