Increase site-description line-height

[emiluzelac]

To fix this small cut-off at the bottom of description, I would recommend increasing the line-height. Here's how this looks like: http://envato.d.pr/171h0/5HHngCXz

Please don't pay attention to what description says, this was for an internal project, not meant to be for this :)

[iamtakashi]

Thanks for the report Emil.

I hesitate to change the line height to keep the vertical rhythm with a baseline grid.

This looks like a side effect of #441, specifically overflow: hidden. Good thing is that since then max size of custom logo has been changed so #440 might not be a legit issue and we could remove #441 so that the cut-off doesn't happen.

We'll test it further.

[emiluzelac]

My pleasure @iamtakashi. Should I close it?

[iamtakashi]

The cut-off issue is legit and we should fix it for the next version anyway, so could you open a new issue and close this PR?

[emiluzelac]

Cool, so create a PR to reverse? #441

[iamtakashi]

No, I think it's usually better to make an issue first and then link a PR to fix the issue if you like.

[iamtakashi]

A new issue made #454.

[emiluzelac]

Cool sorry, I just came back home 👍🏻

On Tuesday, April 12, 2016, Takashi Irie [email protected] wrote:

Closed #452 #452.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#452 (comment)