Skip to content
This repository has been archived by the owner on May 23, 2018. It is now read-only.

Remove white-space: pre-wrap; from <pre> #455

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove white-space: pre-wrap; from <pre> #455

wants to merge 2 commits into from

Conversation

gregrickaby
Copy link

white-space: pre-wrap is fighting the rest of the CSS in this tag. Making any (lengthy) text or code wrapped in a <pre> is difficult to read.

screenshot

WP username: gregrickaby

This is adding line breaks. Any (lengthy) text or code wrapped in a <pre> is difficult to read.

https://dl.dropbox.com/s/oks11g796yldrlm/twentysixteen-remove-pre-wrap.gif?dl=0

WP username: gregrickaby
@karmatosed
Copy link
Member

@iamtakashi this seems good to me, but interested if there was a reason it was there?

@josephfusco
Copy link
Contributor

josephfusco commented May 6, 2016

white-space: pre-wrap issue also exists in Twenty Fifteen. Might have been just carried over in development. I can create that patch if needed.

@karmatosed
Copy link
Member

I'm wondering if the reason this is in would be devices. Have you tested your patch on Windows, Linux and other devices?

@karmatosed
Copy link
Member

Still looking for this to be tested in other devices. @gregrickaby @josephfusco - if you can show me and/or confirm then we can look to get this in for 4.6.

@gregrickaby
Copy link
Author

@karmatosed Here ya go!

Windows 10 - IE 11 - No patch
https://app.crossbrowsertesting.com/public/i94e9360db902757/livetests/5452785/snapshots/z54198c4404117601c10

Windows 10 - IE 11 - Patch
https://app.crossbrowsertesting.com/public/i94e9360db902757/livetests/5452785/snapshots/zff71948cb61c11130ac

Windows 7 - IE 11 - No patch
https://app.crossbrowsertesting.com/public/i94e9360db902757/livetests/5452780/snapshots/z2faa6162dbbabeaf03e

Windows 7 - IE 11 - Patch
https://app.crossbrowsertesting.com/public/i94e9360db902757/livetests/5452780/snapshots/z4453cc062775033fb02

Ubuntu 15.04 - Chrome - No patch
https://app.crossbrowsertesting.com/public/i94e9360db902757/livetests/5452786/snapshots/z98b4e652be76efbde24

Ubuntu 15.04 - Chrome - Patch
https://app.crossbrowsertesting.com/public/i94e9360db902757/livetests/5452786/snapshots/z87000300161f02bc811

Ubuntu 15.04 - Firefox - No patch
https://app.crossbrowsertesting.com/public/i94e9360db902757/livetests/5452789/snapshots/z198d4aece6986be71c5

Ubuntu 15.04 - Firefox - Patch
https://app.crossbrowsertesting.com/public/i94e9360db902757/livetests/5452789/snapshots/zdd23c9473c63d6ffe4b

iOS - Safari 9 - No patch
https://app.crossbrowsertesting.com/public/i94e9360db902757/livetests/5452795/snapshots/zc2e198a7e90cb797271

iOS - Safari 9 - Patch
https://app.crossbrowsertesting.com/public/i94e9360db902757/livetests/5452795/snapshots/z3ec4d0f12841576d8a6

Android - Nexus - Chrome - Patch
https://app.crossbrowsertesting.com/public/i94e9360db902757/livetests/5452793/snapshots/zeeede8745bca20f1c7a

Android - Nexus - Chrome - No patch
https://app.crossbrowsertesting.com/public/i94e9360db902757/livetests/5452793/snapshots/z6264425fa98015cb1f6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants