Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Add 404 template with pattern #183

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Conversation

carolinan
Copy link
Contributor

Description
This replaces #56 _ only because I was not able to pull down the changes._

I made the following changes:

  • Renamed the image file, only removing the -jpeg that was at the end of the name, since the theme will use the webp.
  • Added a wrapping group block and made the columns wide, as seen in the recording on the original Pr.
  • I changed the heading to H1, which meant I needed to hard code the font size value to match the size of the H2 heading.

@carolinan carolinan marked this pull request as ready for review September 3, 2024 06:07
Copy link

github-actions bot commented Sep 3, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan carolinan merged commit a893a1b into trunk Sep 3, 2024
3 checks passed
@cliffralessio
Copy link

Ok perfect @carolinan But will I now result on the list of contributors to this project?

@carolinan
Copy link
Contributor Author

yes!

@carolinan
Copy link
Contributor Author

I copied all the credits from the previous PR.

@cliffralessio
Copy link

Thank you!

@juanfra juanfra deleted the add/404-pattern-and-template branch September 3, 2024 10:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants