Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Added fonts #35

Merged
merged 6 commits into from
Aug 21, 2024
Merged

Added fonts #35

merged 6 commits into from
Aug 21, 2024

Conversation

kafleg
Copy link
Member

@kafleg kafleg commented Aug 16, 2024

Added fonts listed in the styles of Figma.

Copy link

github-actions bot commented Aug 16, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: kafleg <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: aaronjorbin <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan
Copy link
Contributor

Please organize the files in folders, one folder per font family. assets/fonts/name

It looks like the files may have been downloaded using the font library?
This makes it more difficult to identify which file is for which family, since the name is randomized. Long term, this can make it more difficult to maintain the fonts.

Please add the source and license information to the readme.txt file.

@kafleg
Copy link
Member Author

kafleg commented Aug 16, 2024

Please organize the files in folders, one folder per font family. assets/fonts/name

It looks like the files may have been downloaded using the font library? This makes it more difficult to identify which file is for which family, since the name is randomized. Long term, this can make it more difficult to maintain the fonts.

Please add the source and license information to the readme.txt file.

Do I need to upload those fonts in woff2 format or ttf format is also fine?

@carolinan
Copy link
Contributor

carolinan commented Aug 16, 2024

Please use woff2. If it is not included in the google fonts zip, you should be able to get them here https://gwfh.mranftl.com/

@juanfra
Copy link
Member

juanfra commented Aug 16, 2024

Thanks for working on this! Adding to what Carolina said, please be sure that we keep the spacing with tabs instead of spaces for the theme.json file.

Fonts downloaded and converted to woff2 format and updated.

theme.json file is not updated at the moment.
@aaronjorbin
Copy link
Member

theme.json wasn't updated after the files were renamed and put into folders

@carolinan
Copy link
Contributor

If any of these fonts come with variable fonts, those should be used (the google fonts page should say if it is a variable font or not and they would be included in the zip file)

Added the font license that are bundled inside the theme.
readme.txt Outdated

Ysabeau Office Font
License: SIL Open Font License, 1.1, https://opensource.org/licenses/OFL-1.1
Source: https://github.com/CatharsisFonts/Ysabeau
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were the fonts downloaded from the GitHub repositories?
I am asking because sometimes the version on GitHub is not the same as on Google Fonts. Sometimes Google Fonts are not up to date.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I downloaded this font from https://fonts.google.com/

So, do you want me to replace the font from GitHub?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we only need to do that if the Google font version is missing glyphs / have bugs.

The URL can be kept in the readme, but lets not call it "source" if it is not the source, because it can get confusing when trying to update the fonts later.

So I think the file can include both the GitHub link for reference, and the google fonts link as the source?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that sounds good. I think we can do in this way.

Example,

Fira Code Font
Copyright (c) 2014, The Fira Code Project Authors
License: SIL Open Font License, 1.1, https://opensource.org/licenses/OFL-1.1
Reference: https://github.com/tonsky/FiraCode 
Source: https://fonts.google.com/specimen/Fira+Code

Can you verify if this is the right way to do?

@carolinan
Copy link
Contributor

If any of these fonts come with variable fonts, those should be used (the google fonts page should say if it is a variable font or not and they would be included in the zip file)

For example, Fira Code has a variable font inside the zip folder from Google fonts: FiraCode-VariableFont_wght, but it is not a woff2 format.
So it needs to be converted. What converter was used for the other true type files?

All fonts needs to be checked, I just checked one.

@carolinan
Copy link
Contributor

If any of these fonts come with variable fonts, those should be used (the google fonts page should say if it is a variable font or not and they would be included in the zip file)

For example, Fira Code has a variable font inside the zip folder from Google fonts: FiraCode-VariableFont_wght, but it is not a woff2 format. So it needs to be converted. What converter was used for the other true type files?

All fonts needs to be checked, I just checked one.

Do you want to make this update in this PR, or merge this and do follow ups?
Also in theme.json, the order of the font weights varies depending on the font, can we make this consistent? (This becomes irrelevant if the variable fonts are used, so that should be changed first)

@kafleg
Copy link
Member Author

kafleg commented Aug 21, 2024

If any of these fonts come with variable fonts, those should be used (the google fonts page should say if it is a variable font or not and they would be included in the zip file)

For example, Fira Code has a variable font inside the zip folder from Google fonts: FiraCode-VariableFont_wght, but it is not a woff2 format. So it needs to be converted. What converter was used for the other true type files?
All fonts needs to be checked, I just checked one.

Do you want to make this update in this PR, or merge this and do follow ups? Also in theme.json, the order of the font weights varies depending on the font, can we make this consistent? (This becomes irrelevant if the variable fonts are used, so that should be changed first)

Can we merge this and I'll followup in the new PR. I will make the order of the fonts in ascending order.

@carolinan carolinan merged commit ba4b120 into WordPress:trunk Aug 21, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants