-
Notifications
You must be signed in to change notification settings - Fork 111
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Please organize the files in folders, one folder per font family. It looks like the files may have been downloaded using the font library? Please add the source and license information to the readme.txt file. |
Do I need to upload those fonts in woff2 format or ttf format is also fine? |
Please use woff2. If it is not included in the google fonts zip, you should be able to get them here https://gwfh.mranftl.com/ |
Thanks for working on this! Adding to what Carolina said, please be sure that we keep the spacing with tabs instead of spaces for the |
Fonts downloaded and converted to woff2 format and updated. theme.json file is not updated at the moment.
|
If any of these fonts come with variable fonts, those should be used (the google fonts page should say if it is a variable font or not and they would be included in the zip file) |
Added the font license that are bundled inside the theme.
readme.txt
Outdated
|
||
Ysabeau Office Font | ||
License: SIL Open Font License, 1.1, https://opensource.org/licenses/OFL-1.1 | ||
Source: https://github.com/CatharsisFonts/Ysabeau |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were the fonts downloaded from the GitHub repositories?
I am asking because sometimes the version on GitHub is not the same as on Google Fonts. Sometimes Google Fonts are not up to date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I downloaded this font from https://fonts.google.com/
So, do you want me to replace the font from GitHub?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No we only need to do that if the Google font version is missing glyphs / have bugs.
The URL can be kept in the readme, but lets not call it "source" if it is not the source, because it can get confusing when trying to update the fonts later.
So I think the file can include both the GitHub link for reference, and the google fonts link as the source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, that sounds good. I think we can do in this way.
Example,
Fira Code Font
Copyright (c) 2014, The Fira Code Project Authors
License: SIL Open Font License, 1.1, https://opensource.org/licenses/OFL-1.1
Reference: https://github.com/tonsky/FiraCode
Source: https://fonts.google.com/specimen/Fira+Code
Can you verify if this is the right way to do?
For example, Fira Code has a variable font inside the zip folder from Google fonts: FiraCode-VariableFont_wght, but it is not a woff2 format. All fonts needs to be checked, I just checked one. |
The font bundled in the theme is loaded now from theme.json
Do you want to make this update in this PR, or merge this and do follow ups? |
Can we merge this and I'll followup in the new PR. I will make the order of the fonts in ascending order. |
Added fonts listed in the styles of Figma.