Remove contributor section from PR template, add pattern creation guidelines to readme. #45
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
There is small typo in README.md Line no 69
|
README.md
Outdated
|
|
||
| ``` | ||
| <!-- wp:image {"id":125,"sizeSlug":"large","linkDestination":"none"} --> | ||
| <figure class="wp-block-image size-large"><img src="http://wp-stable.test/wp-content/themes/twentytwentyfour/assets/images/project.webp" alt="" class="wp-image-125"/></figure> |
There was a problem hiding this comment.
I think 'twentytwentyfour' will be 'twentytwentyfive'
README.md
Outdated
|
|
||
| ``` | ||
| <!-- wp:image {"sizeSlug":"large","linkDestination":"none"} --> | ||
| <figure class="wp-block-image size-large"><img src="<?php echo esc_url( get_template_directory_uri() ); ?>/assets/images/project.webp" alt="<?php echo esc_attr_x( 'Picture of a building', 'Alt text for project picture', 'twentytwentyfour' ); ?>"/></figure> |
There was a problem hiding this comment.
'twentytwentyfour' to 'twentytwentyfive'
README.md
Outdated
|
|
||
| and | ||
|
|
||
| `<!-- wp:template-part {"slug":"header-portfolio","theme":"twentytwentyfour","area":"header","tagName":"header"} /-->` |
There was a problem hiding this comment.
'twentytwentyfour' to 'twentytwentyfive'
Co-authored-by: Aaron Jorbin <[email protected]>
|
Thanks for the reviews. Merging this one before we start getting contributions for patterns. |
Description