Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Instagram grid: Update the colors of the cover block #506

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Oct 7, 2024

Description
This PR updates the overlay, text, and link color of the cover block in the "Instagram grid" pattern to
make sure that the color contrast works in all style variations.

The new colors are base for the background, and contrast for the text and links.
This color combination has a high enough contrast ratio.

Closes #468

Screenshots
midnight
sunrise
morning
twilight
afternoon
dusk
noon
evening
default

Testing Instructions
Insert the Instagram grid pattern
Test the pattern on all style variations.
Confirm that the text and link are readable.

Note: Tools like WAVE browser extension are not able to find the correct colors in the automated test, so it will report some errors.

Copy link

github-actions bot commented Oct 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Oct 7, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carolinan carolinan added [Type] Bug An existing feature does not function as intended. [Status] Needs Design Feedback Needs general design feedback. labels Oct 7, 2024
@carolinan carolinan merged commit 0d8b245 into trunk Oct 7, 2024
6 checks passed
@juanfra juanfra deleted the update/instagram-grid-color branch October 7, 2024 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Status] Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color problems with the Instagram grid pattern
1 participant