Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Fix: Color problems with "CV/bio" pattern #521

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Fix: Color problems with "CV/bio" pattern #521

merged 1 commit into from
Oct 9, 2024

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Oct 8, 2024

Description

Fixes #471

Update cover blocks to use contrast color for texts to work in different variations.

Screenshots

Screen.Recording.2024-10-08.at.18.25.39.mov

Testing Instructions

  1. Create a page.
  2. Insert the CV/Bio pattern
  3. Test the page with the different style variations.
  4. Confirm that it looks good and the colors follow a11y guidelines.

@juanfra juanfra added [Type] Bug An existing feature does not function as intended. Accessibility (a11y) Needs accessibility testing or feedback [Component] Block Patterns labels Oct 8, 2024
@juanfra juanfra self-assigned this Oct 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: troychaplin <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@juanfra juanfra requested review from beafialho and carolinan October 8, 2024 16:30
carolinan
carolinan approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested all combined variations and the colors are working well, thank you.

@carolinan carolinan merged commit 9ffeba0 into trunk Oct 9, 2024
5 checks passed
@juanfra juanfra deleted the update/cv-bio-pattern branch October 9, 2024 11:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carolinan carolinan carolinan approved these changes

@beafialho beafialho Awaiting requested review from beafialho

Assignees

@juanfra juanfra

Labels
Accessibility (a11y) Needs accessibility testing or feedback [Component] Block Patterns [Type] Bug An existing feature does not function as intended.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Color problems with "CV/bio" pattern
2 participants
@juanfra @carolinan