Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Fix: Update Accent 1 color for Midnight variation. #523

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Oct 8, 2024

Description

Fixes #448

Update the Accent 1 color for Midnight variation to #5644BC

Screenshots

Screen.Recording.2024-10-08.at.18.35.04.mov

Testing Instructions

  1. On the site editor, choose the "Midnight" variation.
  2. Create a page.
  3. Create a group with the "Style 3" style.
  4. Confirm the background is now #5644BC

@juanfra juanfra added the [Type] Bug An existing feature does not function as intended. label Oct 8, 2024
@juanfra juanfra requested review from carolinan and beafialho October 8, 2024 16:39
@juanfra juanfra self-assigned this Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice and passes the color contrast requirements 👍

Copy link

github-actions bot commented Oct 9, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan carolinan merged commit fa0d3da into trunk Oct 9, 2024
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Midnight: Can we utilize section style 3 better?
2 participants