Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Update submenu and overlay color of the header navigation #535

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Oct 9, 2024

Description

This PR adjusts the submenu and overlay text and background colors for the navigation block in the header patterns.
Note that I did not update other patterns like the footers, because they have the overlay turned off by default.

Closes #533

Screenshots
I only recorded the default header. After:

default-header-new-colors.mp4

Testing Instructions

Preview all the headers in the theme and confirm that:
The submenu in the navigation block does not have a white background color (unless white is part of the palette).
The overlay or "mobile menu" does not have white background (unless white is part of the palette).

  1. Add a few menu items to the main navigation block, including a submenu.
  2. Go to Appearance > Editor and select any template to edit.
  3. Click on the "View" icon and select mobile.
  4. Click on the menu button on the navigation block to enable the mobile menu.
  5. Now open the Styles sidebar.
  6. Open "Browse styles" and test the different style variations.
  7. Change the header template part, and repeat.

Copy link

github-actions bot commented Oct 9, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carolinan carolinan marked this pull request as ready for review October 9, 2024 12:30
@carolinan carolinan added the [Type] Enhancement A suggestion for improvement. label Oct 9, 2024
Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good to me.

Screen.Recording.2024-10-09.at.14.50.51.mov

Copy link

github-actions bot commented Oct 9, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@juanfra juanfra merged commit f04ffea into trunk Oct 9, 2024
6 of 7 checks passed
@juanfra juanfra deleted the update/header-navigation-block-color branch October 9, 2024 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation: apply colors to submenus and overlay background
2 participants