Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Try: Remove images to reduce zip size. #536

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Oct 9, 2024

Description

Partial to #401

  • Remove image-from-rawpixel-id-8803077-original.webp and replace it with image-from-rawpixel-id-8802835-jpeg-scaled.webp
  • Replace location.webp with a cropped version export from the Figma comp.
  • Remove avatar and use other image instead. See comment.

Screenshots

Screen.Recording.2024-10-09.at.17.19.04.mov

Testing Instructions

  1. Create a page.
  2. Add the following patterns: "Heading and paragraph with image on the right", "2 columns with avatar" and "Contact location and link".
  3. Confirm that they're using the right images. That the images that are supposed to be removed are removed from the theme and the readme.

@juanfra juanfra added the [Type] Enhancement A suggestion for improvement. label Oct 9, 2024
@juanfra juanfra requested review from carolinan and beafialho October 9, 2024 15:26
@juanfra juanfra self-assigned this Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link

github-actions bot commented Oct 9, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@juanfra
Copy link
Member Author

juanfra commented Oct 11, 2024

@carolinan @beafialho when you have time can you please take a look at the changes here? Thanks 🙌

@beafialho
Copy link
Contributor

Thank you @juanfra! I'm seeing the right images.

@carolinan carolinan merged commit 899b032 into trunk Oct 11, 2024
5 checks passed
@juanfra juanfra deleted the try/reduce-zip-size branch October 11, 2024 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants