Try: Escape apostrophe in translation functions.

[juanfra]

Description

Replacing ’ for an escaped apostrophe (\') in translatable texts.

Screenshots

• N/A

Testing Instructions

1. Create a page.
2. Insert all the patterns modified in this PR.
3. Confirm the texts are looking as they were before.

[github-actions]

Preview changes

You can preview these changes by following the link below:

• Preview changes for twentytwentyfive

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>
Co-authored-by: SergeyBiryukov <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[carolinan]

Why, what is the benefit of this change?

[juanfra]

Why, what is the benefit of this change?

From my experience working with translations, I see that many translators are not technical and don't know about these entities. The benefit would be that it'll be easier for translators to do their work.

I believe historically, in core (and other products I've been involved with), the tendency is to use apostrophes rather than entities.

[carolinan]

That sounds very reasonable to me.

It does not match how these symbols have been managed in the previous bundled themes.
I would like to ask @SergeyBiryukov but he is on vacation until next week.

[carolinan]

I also recognize that on trunk there seems to be a mix of slashes and entities which was not intended :)

[SergeyBiryukov]

Thanks for the PR! I would say these are fine to replace, and I see that some of the previous bundled themes already use the actual double quote characters instead of entities.

However, entities are generally used for better typography, so instead of the escaped apostrophe character, I would suggest using an actual single quote, which would not need escaping and also has a precedent in the previous bundled themes.

Left some suggestions, hope this helps 🙂

[juanfra]

Thank you both!