Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Update/pattern headings #543

Merged
merged 13 commits into from
Oct 11, 2024
Merged

Update/pattern headings #543

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
238fb9b
update: heading on cover with big heading pattern
troychaplin Oct 9, 2024
ba5b90f
update: heading on cv/bio pattern
troychaplin Oct 10, 2024
c7744f4
update: heading on link in bio with tight margins pattern
troychaplin Oct 10, 2024
87f0981
update: heading on cv/bio pattern
troychaplin Oct 10, 2024
8762361
update: heading on cocver with big heading pattern
troychaplin Oct 10, 2024
21c41cb
update: add translate to heading in cover with big heading pattern
troychaplin Oct 10, 2024
9930d91
update: heading on link in bio with tight margins pattern
troychaplin Oct 10, 2024
6ced807
update: translation from x to e
troychaplin Oct 10, 2024
fcb63c3
fix: removed className from block markup
troychaplin Oct 10, 2024
f1bc582
fix: removed className from block markup
troychaplin Oct 10, 2024
056d9b4
change: revert back to previous version of pattern
troychaplin Oct 10, 2024
473586e
Merge branch 'trunk' into update/pattern-headings
troychaplin Oct 10, 2024
10c991b
update: use _x and added context to cv bio pattern, removed empty line
troychaplin Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions patterns/banner-cover-big-heading.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@

<!-- wp:group {"align":"full","layout":{"type":"default"}} -->
<div class="wp-block-group alignfull">
<!-- wp:paragraph {"align":"left","style":{"typography":{"fontSize":"clamp(1rem, 380px, 24vw)","letterSpacing":"-0.02em","lineHeight":"1","fontWeight":"700"}}} -->
<p class="has-text-align-left" style="font-size:clamp(1rem, 380px, 24vw);font-weight:700;letter-spacing:-0.02em;line-height:1"><?php esc_html_e( 'Stories', 'twentytwentyfive' ); ?></p>
<!-- /wp:paragraph -->
<!-- wp:heading {"align":"left","style":{"typography":{"fontSize":"clamp(1rem, 380px, 24vw)","letterSpacing":"-0.02em","lineHeight":"1","fontWeight":"700","fontStyle":"normal"}}} -->
<h2 class="wp-block-heading has-text-align-left" style="font-size:clamp(1rem, 380px, 24vw);font-style:normal;font-weight:700;letter-spacing:-0.02em;line-height:1"><?php echo esc_html_e( 'Stories', 'twentytwentyfive' ); ?></h2>
<!-- /wp:heading -->

</div>
<!-- /wp:group -->
</div>
Expand Down
8 changes: 4 additions & 4 deletions patterns/page-cv-bio.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@
<div class="wp-block-column" style="flex-basis:65%">
<!-- wp:group {"layout":{"type":"flex","orientation":"vertical","justifyContent":"stretch"}} -->
<div class="wp-block-group">
<!-- wp:paragraph {"align":"left","style":{"typography":{"fontSize":"22rem","letterSpacing":"-0.03em"}}} -->
<p class="has-text-align-left" style="font-size:22rem;letter-spacing:-0.03em"><?php echo esc_html_x( 'Hey,', 'Example heading above the content of the CV/Bio pattern.', 'twentytwentyfive' ); ?></p>
<!-- /wp:paragraph -->

<!-- wp:heading {"textAlign":"left","style":{"typography":{"fontSize":"22rem","letterSpacing":"-0.03em","fontStyle":"normal","fontWeight":"300","lineHeight":"1.4"}}} -->
<h2 class="wp-block-heading has-text-align-left" style="font-size:22rem;font-style:normal;font-weight:300;letter-spacing:-0.03em;line-height:1.4"><?php echo esc_html_e( 'Hey,', 'twentytwentyfive' ); ?></h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the esc_html_x here so that there's context for the translators? Hey, is a text that can cause some confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes push in latest commit

<!-- /wp:heading -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix this? It looks like there's an empty space.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes push in latest commit

<!-- wp:paragraph {"className":"is-style-text-subtitle"} -->
<p class="is-style-text-subtitle"><?php echo esc_html_x( 'My name is Nora Winslow Keene, and I&rsquo;m a committed public interest attorney. Living in Denver, Colorado, I&rsquo;ve spent years championing the rights of underrepresented workers. A graduate of Stanford University, I played a key role in securing critical protections for agricultural laborers, ensuring better wages and access to healthcare. My work has focused on advocating for environmental justice and improving the quality of life for rural communities. Every case I take on is driven by the belief that everyone deserves dignity and fair treatment in the workplace.', 'Pattern placeholder text.', 'twentytwentyfive' ); ?></p>
<!-- /wp:paragraph -->
Expand Down
Loading