Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

List block: polish spacing between indented items #544

Merged
merged 1 commit into from
Oct 10, 2024
Merged

List block: polish spacing between indented items #544

merged 1 commit into from
Oct 10, 2024

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Oct 10, 2024 •
edited
Loading

Description
Updates the margin between the list items in theme.json.
Closes #531

Screenshots
image

image

Testing Instructions
Add three list blocks with some indented items: Test both ordered, unordered, and the checkmark style.
Confirm that the spacing is even and sufficient.

@carolinan carolinan added the [Type] Bug An existing feature does not function as intended. label Oct 10, 2024
@github-actions GitHub Actions
Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carolinan carolinan marked this pull request as ready for review October 10, 2024 03:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 10, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: sudip-md <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@sudip-md sudip-md mentioned this pull request Oct 10, 2024
Closed
juanfra
juanfra approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. Works well to me.

Screen.Recording.2024-10-10.at.09.43.14.mov

@carolinan carolinan merged commit 3ad5b42 into trunk Oct 10, 2024
7 checks passed
@juanfra juanfra deleted the update/list branch October 10, 2024 07:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juanfra juanfra juanfra approved these changes

Assignees
No one assigned
Labels
[Type] Bug An existing feature does not function as intended.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List block: polish spacing between indented items
2 participants
@carolinan @juanfra