Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Try: Update instagram grid pattern to use the group (option 2) #551

Closed
wants to merge 1 commit into from

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Oct 10, 2024

Description

Potential fix to #468

I'm updating the Instagram grid to have a group block in the first square, using the section styles and having vertical padding so that it doesn't look too short on mobile.

Screenshots

Screen.Recording.2024-10-10.at.16.39.42.mov

Testing Instructions

  1. Create a page.
  2. Add the pattern.
  3. Test the page in different style variations, confirm that the colors are accessible and look good.
  4. View the page in different viewports, confirm that it looks good.

@juanfra juanfra requested a review from beafialho October 10, 2024 14:55
@juanfra juanfra self-assigned this Oct 10, 2024
Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@juanfra
Copy link
Member Author

juanfra commented Oct 11, 2024

Closing as it was reviewed here and we're going with option 1.

@juanfra juanfra closed this Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant