Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

update: tag line height #554

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

troychaplin
Copy link
Contributor

Description

Fix overlapping tags as noted in #465

Screenshots

Screenshot 2024-10-11 at 12 14 23 AM

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: troychaplin <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, works well. I've tested with different sizes and it adjusts well.

The only thing that I noticed is that in the UI, the line height shown for the variation is 1.5, that's probably Gutenberg territory though. The fix works well.

Screen.Recording.2024-10-11.at.10.06.16.mov

@juanfra juanfra linked an issue Oct 11, 2024 that may be closed by this pull request
@juanfra juanfra added the [Type] Enhancement A suggestion for improvement. label Oct 11, 2024
@juanfra juanfra merged commit d2d5f03 into WordPress:trunk Oct 11, 2024
7 checks passed
@juanfra
Copy link
Member

juanfra commented Oct 11, 2024

I'm not sure why the props bot didn't add the accounts of the people who interacted in the issue as well. But both @unscripted and @kartikmehta8 were not credited.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tags overlap when extending to two lines
2 participants