Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Try: Remove link color in "Link format" pattern. #559

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Oct 11, 2024

Description

Fixes #558

Removing the link color so that it takes the color from the section, which was tested for a11y.

Screenshots

Before

Screen.Recording.2024-10-11.at.11.07.33.mov

After

Screen.Recording.2024-10-11.at.11.06.19.mov

Testing Instructions

  1. Create a page.
  2. Add the link format pattern.
  3. Test the link contrast ratio in all the styles variations and confirm that's accessible.

@juanfra juanfra added the [Type] Enhancement A suggestion for improvement. label Oct 11, 2024
@juanfra juanfra self-assigned this Oct 11, 2024
Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>
Co-authored-by: beafialho <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan
Copy link
Contributor

Yay for easy fixes

@carolinan carolinan merged commit a2b7607 into trunk Oct 11, 2024
5 checks passed
@juanfra juanfra deleted the try/format-link-a11y branch October 11, 2024 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color problems with the link in the "Link Format" pattern
3 participants