This repository has been archived by the owner on Nov 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 113
Add 404 template #56
Closed
Closed
Add 404 template #56
Changes from 22 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
ac98cc6
add patterns fold with hidden-404 file
cliffralessio 3e54b37
Merge branch 'trunk' of https://github.com/cliffralessio/twentytwenty…
cliffralessio d004fa7
Merge branch 'WordPress:trunk' into trunk
cliffralessio 6f57c9a
Add 404 template
cliffralessio fb0e4f1
Merge branch 'trunk' of https://github.com/cliffralessio/twentytwenty…
cliffralessio a22ce28
Remove class wp-image-17 in
cliffralessio be6e9be
Change image with that in figma file and correct some extra blank line
cliffralessio bc20c43
Add License link on readme.txt
cliffralessio 95824ff
Adding some spacing presets and correcting some closures in php
cliffralessio 8a9d981
Fixed formatting issues
cliffralessio 162cda6
Removed @package affiunto by mistake
cliffralessio 7e6bc47
Fixed error Lint:PHP
cliffralessio bb57283
fixed another error in php
cliffralessio b84ad70
Remove Id from image block tag
cliffralessio 298e84b
Add context on escape php functions
cliffralessio e786a5c
Merge branch 'WordPress:trunk' into trunk
cliffralessio 3e04bae
remove some hardcoded dimensions
cliffralessio d60fd0d
resolve php issue
cliffralessio 92a7e09
change some designe issues
cliffralessio 8aa0103
Remove spaces in the final line
cliffralessio dc89319
Remove left and right padding from the columns block
cliffralessio 0a1f258
fixed phpcs
cliffralessio bd99b05
Change custom color on search button and link and className on image
cliffralessio 3b87500
Merge branch 'trunk' into trunk
cliffralessio b43222b
Change layout in columns
cliffralessio 4728aa0
Fix php error
cliffralessio 193b800
Merge branch 'trunk' into trunk
cliffralessio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
<?php | ||
/** | ||
* Title: 404 | ||
* Slug: twentytwentyfive/hidden-404 | ||
* Inserter: no | ||
* | ||
* @package WordPress | ||
* @subpackage Twenty_Twenty_Five | ||
* @since Twenty Twenty-Five 1.0 | ||
*/ | ||
|
||
?> | ||
|
||
<!-- wp:group {"align":"wide","layout":{"type":"constrained","justifyContent":"left"}} --> | ||
<div class="wp-block-group alignwide"> | ||
<!-- wp:columns {"align":"wide","style":{"spacing":{"padding":{"top":"var:preset|spacing|50","bottom":"var:preset|spacing|50"},"blockGap":{"left":"var:preset|spacing|60"}}}} --> | ||
<div class="wp-block-columns alignwide" style="padding-top:var(--wp--preset--spacing--50);padding-bottom:var(--wp--preset--spacing--50)"> | ||
<!-- wp:column {"width":"40%"} --> | ||
<div class="wp-block-column" style="flex-basis:40%"> | ||
<!-- wp:image {"sizeSlug":"large","linkDestination":"none","className":"is-resized"} --> | ||
<figure class="wp-block-image size-large is-resized"> | ||
<img src="<?php echo esc_url( get_template_directory_uri() ); ?>/assets/images/image-from-rawpixel-id-13029755-jpeg.webp" alt="<?php echo esc_attr_x( 'Small totara tree on ridge above Long Point', 'image description', 'twentytwentyfive' ); ?>"/> | ||
</figure> | ||
<!-- /wp:image --> | ||
</div> | ||
<!-- /wp:column --> | ||
|
||
<!-- wp:column {"verticalAlignment":"bottom","width":"60%","style":{"spacing":{"padding":{"left":"var:preset|spacing|40"}}}} --> | ||
<div class="wp-block-column is-vertically-aligned-bottom" style="padding-left:var(--wp--preset--spacing--40);flex-basis:60%"> | ||
<!-- wp:heading {"level":3,"style":{"typography":{"fontStyle":"normal","fontWeight":"500"}}} --> | ||
<h3 class="wp-block-heading" style="font-style:normal;font-weight:500"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The main heading on the page should be an H1. |
||
<?php echo esc_html_x( 'Page not found', '404 error message', 'twentytwentyfive' ); ?> | ||
</h3> | ||
<!-- /wp:heading --> | ||
|
||
<!-- wp:paragraph --> | ||
<p> | ||
<?php echo esc_html_x( 'The page you are looking for doesn\'t exist, or it has been moved. Please try searching using the form below.', '404 error message', 'twentytwentyfive' ); ?> | ||
</p> | ||
<!-- /wp:paragraph --> | ||
|
||
<!-- wp:search {"label":"","placeholder":"<?php echo esc_attr_x( 'Type something...', 'input placeholder text', 'twentytwentyfive' ); ?>","buttonText":"<?php echo esc_attr_x( 'Search', 'button label', 'twentytwentyfive' ); ?>","style":{"border":{"radius":"50px","width":"1px"},"typography":{"fontSize":"18px"}},"borderColor":"opacity-20"} /--> | ||
</div> | ||
<!-- /wp:column --> | ||
</div> | ||
<!-- /wp:columns --> | ||
</div> | ||
<!-- /wp:group --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<!-- wp:template-part {"slug":"header","area":"header","tagName":"header"} /--> | ||
|
||
<!-- wp:group {"tagName":"main","layout":{"type":"constrained","justifyContent":"left"}} --> | ||
carolinan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
<main class="wp-block-group"> | ||
<!-- wp:pattern {"slug":"twentytwentyfive/hidden-404"} /--> | ||
</main> | ||
<!-- /wp:group --> | ||
|
||
<!-- wp:template-part {"slug":"footer","area":"footer","tagName":"footer"} /--> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Image is not resized and linked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the default values when you add an image in the block editor.
If they are removed, the editor has to manually add the class name and change the markup to this:
<!-- wp:image {"id":19,"className":"size-large"} -->
Please motivate why it should be removed?