Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Photo single post: Update post content settings #567

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Oct 14, 2024

Description

When the Photo blog single post template is used, the content in the post editor (block editor) is touching the edge of the editor. It makes the content more difficult to edit.

This pull requests makes some adjustments to the pattern to solve this:

  • It removes the columns block that the content block was placed inside.
  • Changes the alignment from full to wide. This is to make sure that the content continues to be aligned with the rest of the elements on the page, including the featured image above the content.
  • Changes the layout from default to constrained so that the wide and full width alignment options are enabled in the block editor.

Closes #529

Screenshots

Editor, after:
image

Testing Instructions

Go to Appearance > Editor > Templates.
Select the single post template.
In the settings sidebar, open the Template tab.
Locate and open the Design panel.
Select the single post template for the photo blog.
Save.

Create a new post.

Expected result:

  • When you add the first paragraphs they are to the left below the post title, not centered below it.

  • There is a comfortable amount of spacing between the blocks and the edge of the editor.

  • When you add a block that supports wide and full width, such as an image or group, the wide and full width options are available in the block toolbars.

  • When you view the post content on the front, it is not a 100% match to the editor.
    In the editor, the full width block is slightly wider than the wide block. But on the front, full and wide have the same width.
    This is not a bug with the theme.

  • The content is aligned to the left (unless it has been positioned using options!).

  • The content aligns with the rest of the blocks on the page layout.

Test that the layout and the spacing around the content looks correct on different screen widths.

Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carolinan carolinan marked this pull request as ready for review October 14, 2024 07:09
Copy link

github-actions bot commented Oct 14, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how it looks in my local tests, which seems accurate.

Screen.Recording.2024-10-14.at.15.55.25-lw.mov

@carolinan carolinan requested a review from beafialho October 15, 2024 05:11
@beafialho
Copy link
Contributor

I believe this is also working as expected on my end.

Editor Front-end
Captura de ecrã 2024-10-15, às 09 18 29 Captura de ecrã 2024-10-15, às 09 18 22

@carolinan carolinan added the [Type] Bug An existing feature does not function as intended. label Oct 15, 2024
@carolinan
Copy link
Contributor Author

Thank you for testing, lets merge it.

@carolinan carolinan merged commit 2218cee into trunk Oct 15, 2024
7 checks passed
@juanfra juanfra deleted the update/photo-single-posts branch October 15, 2024 08:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Photo single post: It is difficult to edit content in the post editor
3 participants