This repository has been archived by the owner on Nov 18, 2024. It is now read-only.
Morning: Update the color contrast on the button in section style 4 #568
+3
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the text color on the button element in the Morning variation when the button is placed in section style 4, and the button is hovered.
It overrides the text color that is set in styles/sections/section-4.json.
The resulting contrast ratio between the button text and the button text color is 5.08:1
Closes #492
Screenshots
On hover:
Testing Instructions
Go to Appearance > Editor > Styles and enable "Morning".
Create a new post.
Insert a group block and apply section style 4.
In the group, insert a buttons block with a filled button.
Confirm that when you hover over the button, the text color is set to
contrast
.