Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Morning: Update the color contrast on the button in section style 4 #568

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

carolinan
Copy link
Contributor

Description
This PR updates the text color on the button element in the Morning variation when the button is placed in section style 4, and the button is hovered.
It overrides the text color that is set in styles/sections/section-4.json.

The resulting contrast ratio between the button text and the button text color is 5.08:1
Closes #492

Screenshots
On hover:
image

Testing Instructions

Go to Appearance > Editor > Styles and enable "Morning".
Create a new post.
Insert a group block and apply section style 4.
In the group, insert a buttons block with a filled button.
Confirm that when you hover over the button, the text color is set to contrast.

Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link

github-actions bot commented Oct 14, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: troychaplin <[email protected]>
Co-authored-by: beafialho <[email protected]>
Co-authored-by: jasmussen <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan carolinan changed the title Morning: Update the color contrast on the button in section stye 4 Morning: Update the color contrast on the button in section style 4 Oct 14, 2024
@carolinan carolinan added the [Type] Bug An existing feature does not function as intended. label Oct 14, 2024
Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, works well!

Screen.Recording.2024-10-14.at.11.22.00.mov

@juanfra juanfra merged commit 3d1e28d into trunk Oct 14, 2024
6 checks passed
@juanfra juanfra deleted the update/morning-button branch October 14, 2024 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test button color contrast
2 participants