Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Link in bio with profile: Update color of the social icons #569

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Link in bio with profile: Update color of the social icons #569

merged 1 commit into from
Oct 14, 2024

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Oct 14, 2024 •
edited
Loading

Description

The social icons in the "Link in bio with profile" pattern has too low color contrast ratio against the pattern's background color in two of the variations.

This pull request changes the color of the icons to currentColor. The color will be the same as the text color set on the section style that is applied on the pattern.

Closes #557

Screenshots

2024-10-14-social-icons.mp4

Testing Instructions
Note: if you are testing the colors using the Site Editor, please activate the development version of Gutenberg, it includes a fix related to the section style colors.

Insert the "Link in bio with profile, links and wide margins" pattern.
Go to Appearance > Editor > Styles and test the pattern colors with the different combined theme styles.
Confirm that the social icons are visible.

@github-actions GitHub Actions
Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: beafialho <[email protected]>
Co-authored-by: karmatosed <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan carolinan added the [Type] Bug An existing feature does not function as intended. label Oct 14, 2024
juanfra
juanfra approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Works well ✨

Screen.Recording.2024-10-14.at.11.15.16.mov

@juanfra juanfra merged commit 22453f0 into trunk Oct 14, 2024
6 checks passed
@juanfra juanfra deleted the update/bio-social-icon-color branch October 14, 2024 09:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juanfra juanfra juanfra approved these changes

Assignees
No one assigned
Labels
[Type] Bug An existing feature does not function as intended.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Color problems with the social icons in "Link in bio with profile, links and wide margins"
2 participants
@carolinan @juanfra