Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Alternative to "Hero, overlapped book cover with links" without split background #573

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Oct 14, 2024

Description

Fixes #473

This is an alternative version of "Hero, overlapped book cover with links", without the split background, because of the reasons described on the issue.

Screenshots

Screen.Recording.2024-10-14.at.18.37.21.mov

Testing Instructions

  1. Create a page.
  2. Add the pattern.
  3. Confirm that's working well with the different style variations and in different viewports, and that's looking like the updated version on figma.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>
Co-authored-by: beafialho <[email protected]>
Co-authored-by: jasmussen <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@beafialho
Copy link
Contributor

Thank you, it's looking good!

@carolinan carolinan merged commit 9143457 into trunk Oct 15, 2024
6 checks passed
@juanfra juanfra deleted the update/book-overlapped-pattern branch October 15, 2024 09:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color problems with "Hero, overlapped book cover with links"
3 participants