Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Remove the block binding #574

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Remove the block binding #574

merged 1 commit into from
Oct 17, 2024

Conversation

carolinan
Copy link
Contributor

Description
This PR removes the copyright block binding because the format of the copyright notice is incorrect.
The copyright notice in the footers is replaced with the theme name.

Partial for #571

Testing Instructions

Confirm that the theme name is showing at the bottom left of

  • The default footer
  • Footer with columns
  • Footer with newsletter signup

And in the Portfolio homepage template.

Copy link

github-actions bot commented Oct 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: 2ndkauboy <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, works well! The only thing I'm doubtful is if we have to pass Twenty Twenty-Five to translation functions. I believe, just like WordPress, these stay the same in every language and that's the intention.

Screen.Recording.2024-10-15.at.11.03.57.mov

@carolinan
Copy link
Contributor Author

The way it was explained to me many many years ago was that it needs to be translation ready because the script is different. WordPress in for example Arabic is ووردبريس but an URL like wordpress.org is wordpress.org

@2ndkauboy
Copy link

Wouldn't it make more sense to use the "Site Title" instead of the theme name? Only in some footers we would have the site title twice then.

I don't really think the theme name - with no link - does make sense for most users. The site name kind of makes sense.

Or just don't have the whole "left column" at all, if it would duplicate the site title? 🤔

@carolinan
Copy link
Contributor Author

carolinan commented Oct 15, 2024

I agree with using the site title, or even using the site tagline, but I know that @beafialho asked for the theme name.

@carolinan
Copy link
Contributor Author

In my opinion if the left side was left empty it may look unbalanced

@2ndkauboy
Copy link

@carolinan this is what I've meant: #578

@juanfra
Copy link
Member

juanfra commented Oct 16, 2024

The way it was explained to me many many years ago was that it needs to be translation ready because the script is different. WordPress in for example Arabic is ووردبريس but an URL like wordpress.org is wordpress.org

Thanks for clarifying, Carolina!

Regarding having the site title, as mentioned, it was discussed and the problem is redundancy. It'd be displayed two times in a small piece of "real estate".

In my opinion if the left side was left empty it may look unbalanced

I fully agree with this.

If we want to discuss the modification of the footer, I'd suggest we open a new issue and discuss it there. @beafialho carefully crafted the design of the different footers (and the theme!), so I'd prefer if we ran any of these things with her first.

@beafialho
Copy link
Contributor

The footer was designed to have the site title (above) and the theme name showing discretely at the bottom (like many other themes do). I suggest we keep it like that.

Captura de ecrã 2024-10-16, às 10 13 58

@beafialho
Copy link
Contributor

We could however, for clarity, add Twenty Twenty-Five Theme instead of only Twenty Twenty-Five. I realise it may be somewhat abstract for users who aren't familiar with WordPress' default themes.

@juanfra
Copy link
Member

juanfra commented Oct 16, 2024

I'd personally prefer just Twenty Twenty-Five, but I could be biased as I believe Twenty Twenty-Five Theme wouldn't translate well to Spanish.

@juanfra
Copy link
Member

juanfra commented Oct 17, 2024

Thanks again Carolina, let's move forward with the theme name translated for now. And in case we need to make an adjustment we can revisit it later. Thank you all!

@juanfra juanfra merged commit d3e09fe into trunk Oct 17, 2024
5 checks passed
@juanfra juanfra deleted the update/remove-block-binding branch October 17, 2024 14:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants