-
Notifications
You must be signed in to change notification settings - Fork 111
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Preview changesYou can preview these changes by following the link below: I will update this comment with the latest preview links as you push more changes to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, works well! The only thing I'm doubtful is if we have to pass Twenty Twenty-Five
to translation functions. I believe, just like WordPress
, these stay the same in every language and that's the intention.
Screen.Recording.2024-10-15.at.11.03.57.mov
The way it was explained to me many many years ago was that it needs to be translation ready because the script is different. WordPress in for example Arabic is |
Wouldn't it make more sense to use the "Site Title" instead of the theme name? Only in some footers we would have the site title twice then. I don't really think the theme name - with no link - does make sense for most users. The site name kind of makes sense. Or just don't have the whole "left column" at all, if it would duplicate the site title? 🤔 |
I agree with using the site title, or even using the site tagline, but I know that @beafialho asked for the theme name. |
In my opinion if the left side was left empty it may look unbalanced |
@carolinan this is what I've meant: #578 |
Thanks for clarifying, Carolina! Regarding having the site title, as mentioned, it was discussed and the problem is redundancy. It'd be displayed two times in a small piece of "real estate".
I fully agree with this. If we want to discuss the modification of the footer, I'd suggest we open a new issue and discuss it there. @beafialho carefully crafted the design of the different footers (and the theme!), so I'd prefer if we ran any of these things with her first. |
We could however, for clarity, add |
I'd personally prefer just |
Thanks again Carolina, let's move forward with the theme name translated for now. And in case we need to make an adjustment we can revisit it later. Thank you all! |
Description
This PR removes the copyright block binding because the format of the copyright notice is incorrect.
The copyright notice in the footers is replaced with the theme name.
Partial for #571
Testing Instructions
Confirm that the theme name is showing at the bottom left of
And in the Portfolio homepage template.