Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

News blog with featured posts grid: Replace footer #577

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Oct 15, 2024

Description

This PR closes #404 and replaces #572

It replaces the footer with the newsletter-signup with the footer with the columns in the pattern
"News blog with featured posts grid".

In order to add the footer with the columns, a new footer template part was created, to make it easier for users to use the same footer across the site, if they want.

Screenshots
After:

image

Testing Instructions

Go to Appearance > Editor > Templates.
Select the blog home template.
In the Template tab, open the Design panel.
Select the design "News blog with featured posts grid".
Preview the footer.
Confirm that the newsletter-signup pattern shows above the footer with the columns (two columns with lists of links).

Copy link

github-actions bot commented Oct 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: alaminfirdows <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carolinan carolinan added the [Type] Bug An existing feature does not function as intended. label Oct 15, 2024
Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, works well!

Screen.Recording.2024-10-15.at.10.54.16.mov

@carolinan carolinan merged commit 28aa8ab into trunk Oct 15, 2024
6 checks passed
@juanfra juanfra deleted the add/footer-columns-part branch October 15, 2024 09:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visible gap between the footer and the Newsletter signup pattern
2 participants