Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Try: Post format binding. #608

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Try: Post format binding. #608

merged 4 commits into from
Oct 21, 2024

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Oct 21, 2024

Description

Cherry-picking the post format binding from #576

Screenshots

N/A

Testing Instructions

  1. Create one or more posts with formats.
  2. Insert the pattern where you want to test it, in a template, or content.

@juanfra juanfra added the [Type] Enhancement A suggestion for improvement. label Oct 21, 2024
@juanfra juanfra requested a review from carolinan October 21, 2024 16:32
Copy link

github-actions bot commented Oct 21, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carolinan
Copy link
Contributor

oops :p

@carolinan
Copy link
Contributor

I closed mine, I was too slow.

It needs a category and description.

@juanfra
Copy link
Member Author

juanfra commented Oct 21, 2024

Thanks Carolina, added the categories and description.

@carolinan
Copy link
Contributor

Hmm are we keeping the pattern as small text? I don't have a strong feeling about it.

@juanfra
Copy link
Member Author

juanfra commented Oct 21, 2024

Maybe we can merge it as is, so that we have it in, and then run it by Bea so that she can decide?

@carolinan
Copy link
Contributor

Ah, the hook is missing, I am getting "Invalid source" under "Attributes" in the block editor.

@juanfra
Copy link
Member Author

juanfra commented Oct 21, 2024

Thanks! I pushed the changes.

@carolinan
Copy link
Contributor

Thank you.

@carolinan carolinan merged commit 345f756 into trunk Oct 21, 2024
4 checks passed
@juanfra juanfra deleted the try/post-format-binding branch October 21, 2024 18:01
@juanfra
Copy link
Member Author

juanfra commented Oct 21, 2024

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants