Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Update heading font size #630

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Update heading font size #630

merged 2 commits into from
Oct 24, 2024

Conversation

beafialho
Copy link
Contributor

Description

Unfortunately this is a workaround to the intended behaviour of this heading. It should ideally stretch to match the content width in all variations, but that isn't possible currently in the editor. Fixes #627. Here's how it should look with the updated font size:

Screenshots

Captura de ecrã 2024-10-24, às 16 52 14
Captura de ecrã 2024-10-24, às 16 35 36
Captura de ecrã 2024-10-24, às 16 35 07
Captura de ecrã 2024-10-24, às 16 34 00
Captura de ecrã 2024-10-24, às 16 32 18

Testing Instructions

  1. Insert the pattern
  2. Confirm it looks like the above across variations

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: beafialho <[email protected]>
Co-authored-by: juanfra <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bea, looks good. I adjusted the code because it was giving a block validation error.

Screen.Recording.2024-10-24.at.18.42.07.mov

@juanfra juanfra merged commit 4e572d0 into trunk Oct 24, 2024
5 checks passed
@juanfra juanfra deleted the grid-pattern-font-size branch October 24, 2024 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Call to action with grid layout with products and link" title displays in two lines for some variations.
2 participants