Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Translations: edits for capitalization and consistency #632

Merged
merged 6 commits into from
Oct 30, 2024

Conversation

sabernhardt
Copy link
Contributor

@sabernhardt sabernhardt commented Oct 25, 2024

  1. Capitalize proper nouns: African, YouTube, and Acropolis of Athens.
  2. Use lowercase t for translators: comments.
  3. Add a period in the context when it matches another string.
  4. Use plural "IRL events" in services-subscriber-only-section.php for consistency with the string in pricing patterns.

Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link

github-actions bot commented Oct 25, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sabernhardt <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@@ -29,7 +29,7 @@
<p class="has-text-align-center has-small-font-size">
<?php
printf(
/* Translators: Designed with WordPress. %s: WordPress link. */
/* translators: Designed with WordPress. %s: WordPress link. */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Maybe there are other tools where it does not work. I don't know the reason behind this requirement.

@@ -28,7 +28,7 @@
<!-- /wp:list-item -->

<!-- wp:list-item {"fontSize":"medium"} -->
<li class="has-medium-font-size"><?php esc_html_e( 'Join our IRL event.', 'twentytwentyfive' ); ?></li>
<li class="has-medium-font-size"><?php esc_html_e( 'Join our IRL events.', 'twentytwentyfive' ); ?></li>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -85,7 +85,7 @@
<div class="wp-block-group has-small-font-size">
<!-- wp:post-terms {"term":"category","style":{"typography":{"textTransform":"uppercase","letterSpacing":"1.4px"}}} /-->
<!-- wp:paragraph -->
<p><?php echo esc_html_x( '·', 'Separator between date and categories', 'twentytwentyfive' ); ?></p>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -44,7 +44,7 @@

<!-- wp:query-no-results -->
<!-- wp:paragraph -->
<p><?php echo esc_html_x( 'Sorry, but nothing was found. Please try a search with different keywords.', 'Message explaining that there are no results returned from a search', 'twentytwentyfive' ); ?></p>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carolinan
Copy link
Contributor

If I understand correctly, all text string changes require approval from the polyglots team after RC1.

@sabernhardt
Copy link
Contributor Author

I'll mention this in Slack #polyglots.

My spreadsheet might not have much value now, but I should share it somewhere.

  • The first sheet groups the strings from functions.php and from within the content of patterns.
  • The second sheet contains all 489 strings from translate.wordpress.org.

@carolinan carolinan added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Oct 29, 2024
Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have applied the PR and confirmed that there were no block validation errors in the updated patterns.

@juanfra juanfra requested a review from audrasjb October 30, 2024 09:38
Copy link
Contributor

@audrasjb audrasjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a GTE and Locale Manager for fr_FR (and core committer) I approve these changes. Some of them are not super important (like Translators -> translators) but some other changes are more relevant for a post-String freeze inclusion.

@juanfra juanfra merged commit 349defc into WordPress:trunk Oct 30, 2024
12 of 14 checks passed
@juanfra
Copy link
Member

juanfra commented Oct 30, 2024

Thank you all!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants