-
Notifications
You must be signed in to change notification settings - Fork 111
Translations: edits for capitalization and consistency #632
Conversation
Preview changesYou can preview these changes by following the link below: I will update this comment with the latest preview links as you push more changes to this PR. Note The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
@@ -29,7 +29,7 @@ | |||
<p class="has-text-align-center has-small-font-size"> | |||
<?php | |||
printf( | |||
/* Translators: Designed with WordPress. %s: WordPress link. */ | |||
/* translators: Designed with WordPress. %s: WordPress link. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalized "Translators:" apparently works correctly, too.
https://translate.wordpress.org/projects/wp-themes/twentytwentyfive/fr/default/?filters%5Bterm%5D=Designed+with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Maybe there are other tools where it does not work. I don't know the reason behind this requirement.
@@ -28,7 +28,7 @@ | |||
<!-- /wp:list-item --> | |||
|
|||
<!-- wp:list-item {"fontSize":"medium"} --> | |||
<li class="has-medium-font-size"><?php esc_html_e( 'Join our IRL event.', 'twentytwentyfive' ); ?></li> | |||
<li class="has-medium-font-size"><?php esc_html_e( 'Join our IRL events.', 'twentytwentyfive' ); ?></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Combines similar strings:
https://translate.wordpress.org/projects/wp-themes/twentytwentyfive/fr/default/?filters%5Bterm%5D=IRL
@@ -85,7 +85,7 @@ | |||
<div class="wp-block-group has-small-font-size"> | |||
<!-- wp:post-terms {"term":"category","style":{"typography":{"textTransform":"uppercase","letterSpacing":"1.4px"}}} /--> | |||
<!-- wp:paragraph --> | |||
<p><?php echo esc_html_x( '·', 'Separator between date and categories', 'twentytwentyfive' ); ?></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the period at the end of the context, this created a separate string.
https://translate.wordpress.org/projects/wp-themes/twentytwentyfive/fr/default/?filters%5Bterm%5D=Separator+between+date+and+categories
@@ -44,7 +44,7 @@ | |||
|
|||
<!-- wp:query-no-results --> | |||
<!-- wp:paragraph --> | |||
<p><?php echo esc_html_x( 'Sorry, but nothing was found. Please try a search with different keywords.', 'Message explaining that there are no results returned from a search', 'twentytwentyfive' ); ?></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches the context to the more common version, with the period.
https://translate.wordpress.org/projects/wp-themes/twentytwentyfive/fr/default/?filters%5Bterm%5D=Sorry%2C+but+nothing+was+found
If I understand correctly, all text string changes require approval from the polyglots team after RC1. |
I'll mention this in Slack #polyglots. My spreadsheet might not have much value now, but I should share it somewhere.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have applied the PR and confirmed that there were no block validation errors in the updated patterns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a GTE and Locale Manager for fr_FR (and core committer) I approve these changes. Some of them are not super important (like Translators
-> translators
) but some other changes are more relevant for a post-String freeze inclusion.
Thank you all! |
translators:
comments.services-subscriber-only-section.php
for consistency with the string in pricing patterns.