Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Fix: Parity between style variations and colors + typography presets. #635

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Oct 25, 2024

Description

Fixes #634

Fixing parity between style variations and colors + typography presets.

Screenshots

Screen.Recording.2024-10-25.at.16.36.19.mov

Testing Instructions

  1. Open the site editor.
  2. Click on all the style variations.
  3. Confirm that each time one is selected, then the correspondent palette and typography should be also selected.

@juanfra juanfra added the [Type] Bug An existing feature does not function as intended. label Oct 25, 2024
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>
Co-authored-by: beafialho <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@beafialho
Copy link
Contributor

Thank you @juanfra, these are looking good to me now. The combined variations are "linked" with the typography presets when I select them, as expected.

@juanfra
Copy link
Member Author

juanfra commented Oct 25, 2024

Thank you Bea!

@juanfra juanfra merged commit 1af1429 into trunk Oct 25, 2024
5 checks passed
@juanfra juanfra deleted the update/color-palette-parity branch October 25, 2024 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color palette and font presets are not shown as selected when the combined variation is active
2 participants