Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Alt: FAQs: Replace Details blocks with headings and separators. #646

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Oct 28, 2024

Description

Fixes #638

Alternative to #639 - based on @beafialho's comment here.

I can't edit fork branches, so I created this PR. Props to @sabernhardt, @beafialho, @carolinan

Screenshots

Screen.Recording.2024-10-28.at.15.31.56.mov

Testing Instructions

  1. Create a page.
  2. Add the FAQ pattern.
  3. Confirm that it looks like what Bea proposed here.

Copy link

github-actions bot commented Oct 28, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>
Co-authored-by: beafialho <[email protected]>
Co-authored-by: audrasjb <[email protected]>
Co-authored-by: sabernhardt <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Contributor

@beafialho beafialho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @juanfra! Looks good to me.

@sabernhardt
Copy link
Contributor

One more change: The word "toggle" in the pattern description would not fit the columns layout.

@sabernhardt
Copy link
Contributor

Thanks for the update!

Summary of proposed translation changes:

  • Remove "toggle" from FAQ pattern description: "A FAQs section with a FAQ heading and list of questions and answers."
  • Trim the sample answer to one sentence instead of two: "This exquisite compilation showcases a diverse array of photographs that capture the essence of different eras and cultures, reflecting the unique styles and perspectives of each artist."
  • Remove one sample question ("Will The Stories Book be available in other languages other that English?").

@carolinan carolinan added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Oct 29, 2024
@juanfra juanfra requested a review from audrasjb October 30, 2024 09:38
Copy link
Contributor

@audrasjb audrasjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a GTE and Locale Manager for fr_FR (and core committer) I approve these changes to be included post-String freeze.

@juanfra
Copy link
Member Author

juanfra commented Oct 30, 2024

Thank you!

@juanfra juanfra merged commit b54a013 into trunk Oct 30, 2024
6 checks passed
@juanfra juanfra deleted the try/alt-faq-pattern branch October 30, 2024 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace the Details blocks in the FAQs pattern
5 participants