-
Notifications
You must be signed in to change notification settings - Fork 113
Alt: FAQs: Replace Details blocks with headings and separators. #646
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Preview changesYou can preview these changes by following the link below: I will update this comment with the latest preview links as you push more changes to this PR. Note The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @juanfra! Looks good to me.
One more change: The word "toggle" in the pattern description would not fit the columns layout. |
Thanks for the update! Summary of proposed translation changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a GTE and Locale Manager for fr_FR (and core committer) I approve these changes to be included post-String freeze.
Thank you! |
Description
Fixes #638
Alternative to #639 - based on @beafialho's comment here.
I can't edit fork branches, so I created this PR. Props to @sabernhardt, @beafialho, @carolinan
Screenshots
Screen.Recording.2024-10-28.at.15.31.56.mov
Testing Instructions