Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Ensure Quote Block Borders are Visible Across All Color Variations and Sections #654

Closed
wants to merge 3 commits into from

Conversation

alaminfirdows
Copy link
Contributor

Description
Closes #653

This PR resolves the issue, and now the borders of quote blocks are displayed in all themes by removing the border color from theme.json.

Screenshots
image

Testing Instructions

  1. Start by creating a new page or post.
  2. Add a "Group" block and apply "Section Style 5" to it.
  3. Within this group, insert a "Quote" block.
  4. Preview the page or post.

Copy link

github-actions bot commented Oct 29, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: alaminfirdows <[email protected]>
Co-authored-by: beafialho <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Oct 29, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carolinan carolinan requested a review from beafialho October 30, 2024 03:55
@beafialho
Copy link
Contributor

Thank you for finding this one and submitting the PR.

I spotted two issues:

  • Dusk: Styles 2, 4 and 5 aren't looking accessible (including the border)
dusk-quote.mp4
  • Sunrise: Styles 1, 2, 3, 4 aren't looking accessible (including the border)
sunrise-quote.mp4

Not sure if this should to be addressed in this PR or another.

@beafialho beafialho requested a review from juanfra October 30, 2024 09:44
@carolinan
Copy link
Contributor

I think this text color issue should be fixed in #619 since it already adjusts the color for several other blocks?

@juanfra
Copy link
Member

juanfra commented Oct 30, 2024

As requested, I pushed a fix here.

@juanfra
Copy link
Member

juanfra commented Nov 4, 2024

I'm closing this one as it was fixed in the other PR. Thanks for your contribution, I've added credits to all here.

@beafialho beafialho closed this Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The borders of the quote block are not visible for some color variations and sections.
4 participants