This repository has been archived by the owner on Nov 18, 2024. It is now read-only.
Add font sizes #93
Merged
Add font sizes #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
carolinan
commented
Aug 20, 2024
carolinan
commented
Aug 20, 2024
Closed
|
I checked this PR with @MichelleBulloch in a call and showed her how to test the PR. She is interested to learn and contribute. :) |
juanfra
reviewed
Aug 20, 2024
| }, | ||
| "h1": { | ||
| "typography": { | ||
| "fontSize": "70px" |
| }, | ||
| "h2": { | ||
| "typography": { | ||
| "fontSize": "48px" |
carolinan
added
the
[Status] Needs Design Feedback
Co-authored-by: Juan Aldasoro <[email protected]>
Co-authored-by: Juan Aldasoro <[email protected]>
Co-authored-by: Juan Aldasoro <[email protected]>
Co-authored-by: Juan Aldasoro <[email protected]>
Co-authored-by: Juan Aldasoro <[email protected]>
carolinan
commented
Aug 20, 2024
Co-authored-by: Juan Aldasoro <[email protected]>
Co-authored-by: Juan Aldasoro <[email protected]>
juanfra
approved these changes
Aug 21, 2024
This was referenced Aug 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A first go at adding the font sizes.
Closes #36
Screenshot
Testing Instructions
Site title, tagline, search, code, post date.