Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Try link and focus styles #94

Merged
merged 16 commits into from
Aug 26, 2024
Merged

Try link and focus styles #94

merged 16 commits into from
Aug 26, 2024

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Aug 20, 2024

Description
This PR adds text decoration thickness and underline offset for links.
This style is enqueued both in the editors and the front, using style.css and editor-style.css

It also adds a solid outline with 2px width on focus, to all focusable elements.
This style is only enqueued on the front, using style.css.
I did not add this style the editor, because it affected the way the blocks look when they are selected, and in my opinion, this can make the blocks more difficult to work with.

The PR Uses get_parent_theme_file_uri() so that the files are enqueued also for child themes. Please correct me if this is wrong!

For #72 #6

Screenshots

Testing Instructions

@carolinan carolinan marked this pull request as ready for review August 20, 2024 12:19
Copy link

github-actions bot commented Aug 20, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: justintadlock <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan carolinan added the [Status] In discussion Used to indicate that an issue is in the process of being discussed label Aug 20, 2024
functions.php Outdated Show resolved Hide resolved
@beafialho
Copy link
Contributor

beafialho commented Aug 22, 2024

Could we add the hover state as well? Or maybe address that in another issue? I realised I haven't specified that in the Figma file.

@beafialho
Copy link
Contributor

I have added the links hover states here, if it's helpful. Let me know if I missed any.

@carolinan
Copy link
Contributor Author

If the hover styles can be added in theme.json, that would be better. If it doesn't work, we can use the css files.

Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I left a few comments.

functions.php Outdated Show resolved Hide resolved
functions.php Show resolved Hide resolved
functions.php Outdated Show resolved Hide resolved
functions.php Outdated Show resolved Hide resolved
functions.php Show resolved Hide resolved
functions.php Outdated Show resolved Hide resolved
functions.php Outdated Show resolved Hide resolved
functions.php Show resolved Hide resolved
functions.php Outdated Show resolved Hide resolved
@carolinan
Copy link
Contributor Author

Eh no the contact pattern is not supposed to be on this branch o.o

@carolinan carolinan merged commit 6391636 into trunk Aug 26, 2024
3 checks passed
@juanfra juanfra deleted the try/link-and-focus branch August 29, 2024 11:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Status] In discussion Used to indicate that an issue is in the process of being discussed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants