This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Rename footers appropriately #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #628 . Related in part to #548 (shouldn't need to update the footer patterns in that fix). Also addresses minor text string changes (#584) to make the content a bit more general (i.e. work for personal, and business sites).
Screenshots
Testing Instructions
Go to the site editor > footers view and see the three footer options. There should be no changes to the footers, only the titles/slugs. Then search for
portfolioand you shouldn't see the footer portfolio.