This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Tweak styles #649
Merged
Tweak styles #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styles/ice.json
Outdated
| }, | ||
| "layout": { | ||
| "contentSize": "620px", | ||
| "wideSize": "99vw" |
There was a problem hiding this comment.
this makes wide width content virtually full width. I suppose that's the intent, just pointing it out
There was a problem hiding this comment.
The home looks a little weird on really big screens
MaggieCabrera
approved these changes
Oct 16, 2023
luminuu
reviewed
Oct 16, 2023
styles/rust.json
Outdated
| @@ -47,49 +57,6 @@ | |||
| "layout": { | |||
| "contentSize": "620px", | |||
| "wideSize": "90vw" | |||
There was a problem hiding this comment.
As Maggie mentioned above for the Ice style variation, I noticed the same with Rust too - however it was already here before. I find this a bit unlucky, as on larger screens and especially curved monitors with a wide width, these layouts would look pretty much out of place.
There was a problem hiding this comment.
I'll remove it on rust too.
richtabor
force-pushed
the
tweak/styles
branch
from
002316c to
9d19fdb
Compare
|
Updated the styles to this: CleanShot.2023-10-16.at.12.55.03.mp4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more gradients/duotones, and makes ice more unique.
Props @beafialho.