This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Fix system-serif slug type-o #740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See issue #741 |
|
We will close this repo since it's gotten out of sync with core. Can you make this PR in https://github.com/WordPress/wordpress-develop/ instead? I think it's still a legitimate fix |
|
Done! Track ticket https://core.trac.wordpress.org/ticket/60325 and PR for code review WordPress/wordpress-develop#5933 :) |
|
Thank you so much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When trying the set, for example, the global headings font family to System Serif, the global style setting will be converted to style rule
font-family: var(--wp--preset--font-family--system-Serif);(notice the upper case S) referencing a non-existent root variable.Testing Instructions
--wp--preset--font-family--system-serif(notice the lower case S) value.