Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full RFC6238 Compatibility #207

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Commits on Dec 22, 2017

  1. Full RFC6238 Compatibility

    The full TOTP specification supports not only SHA1, but also SHA256 and SHA512. Up til now, the TOTP provider in this plugin (and most other PHP implementations) claims to support a specified hash type, but doesn't actually work with anything other than SHA1.
    
    This is due to key lengths and hash lengths being _different_ for the three hash variants.
    
    This change introcudes support for both SHA256 and SHA512, porting the implementation directly from https://github.com/ericmann/totp.
    
    See https://tools.ietf.org/html/rfc6238#section-1.2 for more information on the `MAY USE` notation for SHA256 and SHA512.
    
    See https://tools.ietf.org/html/rfc6238#appendix-A for a fully compliant reference implementation in Java.
    
    See https://tools.ietf.org/html/rfc6238#appendix-B for test vectors showing TOTPs generated for specific time values and the three hash variants.
    
    See https://github.com/ericmann/totp/blob/master/test/phpunit/ReferenceTest.php for example unit tests verifying this particular implementation before it was ported to the plugin.
    Eric Mann committed Dec 22, 2017
    Configuration menu
    Copy the full SHA
    8374292 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2018

  1. Sync latest

    ericmann committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    685ea19 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    665b11f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9c7d057 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2021

  1. Sync upstream

    ericmann committed May 18, 2021
    Configuration menu
    Copy the full SHA
    6e44438 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    71c2cf5 View commit details
    Browse the repository at this point in the history
  3. Revert "Use class defaults. Props @kasparsd"

    This reverts commit 71c2cf5.
    ericmann committed May 18, 2021
    Configuration menu
    Copy the full SHA
    b2f0fb0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    11cf572 View commit details
    Browse the repository at this point in the history