-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full RFC6238 Compatibility #207
Open
ericmann
wants to merge
8
commits into
WordPress:master
Choose a base branch
from
ericmann:totp-parity
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Dec 22, 2017
-
The full TOTP specification supports not only SHA1, but also SHA256 and SHA512. Up til now, the TOTP provider in this plugin (and most other PHP implementations) claims to support a specified hash type, but doesn't actually work with anything other than SHA1. This is due to key lengths and hash lengths being _different_ for the three hash variants. This change introcudes support for both SHA256 and SHA512, porting the implementation directly from https://github.com/ericmann/totp. See https://tools.ietf.org/html/rfc6238#section-1.2 for more information on the `MAY USE` notation for SHA256 and SHA512. See https://tools.ietf.org/html/rfc6238#appendix-A for a fully compliant reference implementation in Java. See https://tools.ietf.org/html/rfc6238#appendix-B for test vectors showing TOTPs generated for specific time values and the three hash variants. See https://github.com/ericmann/totp/blob/master/test/phpunit/ReferenceTest.php for example unit tests verifying this particular implementation before it was ported to the plugin.
Eric Mann committedDec 22, 2017 Configuration menu - View commit details
-
Copy full SHA for 8374292 - Browse repository at this point
Copy the full SHA 8374292View commit details
Commits on Mar 2, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 685ea19 - Browse repository at this point
Copy the full SHA 685ea19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 665b11f - Browse repository at this point
Copy the full SHA 665b11fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c7d057 - Browse repository at this point
Copy the full SHA 9c7d057View commit details
Commits on May 18, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 6e44438 - Browse repository at this point
Copy the full SHA 6e44438View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71c2cf5 - Browse repository at this point
Copy the full SHA 71c2cf5View commit details -
Revert "Use class defaults. Props @kasparsd"
This reverts commit 71c2cf5.
Configuration menu - View commit details
-
Copy full SHA for b2f0fb0 - Browse repository at this point
Copy the full SHA b2f0fb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11cf572 - Browse repository at this point
Copy the full SHA 11cf572View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.