Backup Codes: Always generate 10 codes via REST #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll fix the tests. We should probably remove the |
iandunn
force-pushed
the
rest-10-codes
branch
from
99ec9be
to
ca60c3f
Compare
iandunn
added a commit
to WordPress/wporg-two-factor
that referenced
this pull request
Feb 9, 2023
Those are being removed from the upstream API. `10 / replace` are the defaults anyway. Aside: `method` was never correct, it should have been `append: false` for `replace`. See WordPress/two-factor#514
15 tasks
The internal function accepts a param for flexibility, but currently there's no use case for letting the user choose how many they want.
iandunn
force-pushed
the
rest-10-codes
branch
from
ca60c3f
to
2efc94e
Compare
dd32
approved these changes
Feb 10, 2023
pkevan
approved these changes
Feb 10, 2023
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal function accepts a param for flexibility, but currently there's no use case for letting the user choose how many they want.
This should be included in the same release as #504, since it was introduced there.
Props @xknown
See WordPress/wporg-two-factor#3