Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow doaction.org URLs for events #1350

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Conversation

dd32
Copy link
Member

@dd32 dd32 commented Jul 25, 2024

This PR (is untested) is intended to allow saving of doaction.org URL formats for Events.

This is not an ideal PR, as it's hacky in nature, as the existing post type infrastructure really assumes that the only events are going to be ones hosted by the networks, and doesn't really fully support externally hosted sites for new sites.

This PR simply avoids some of the UI for such urls, and allows it to be saved.

I'm sure this could be more tightly integrated with a proper url validation and whatnot, but this might be enough until the question of "what to do with doaction.org" is resolved.

Fixes #1335

Props ,

Screenshots

How to test the changes in this Pull Request:

@dorsvenabili
Copy link
Collaborator

Thank you for fixing this issue, Dion!

I'm wondering, will this fix allow Do_Action events to be shown in events.wordpress.org? Because we need that.

Let me know and I'll open another issue if needed, thanks! :)

@dorsvenabili
Copy link
Collaborator

Hi @dd32, any updates about if we can already add Do_Action URLs to the WordCamp CPT's sites field?
Thanks!

@dd32 dd32 requested a review from pkevan August 9, 2024 02:43
@pkevan
Copy link
Contributor

pkevan commented Aug 12, 2024

I'm wondering, will this fix allow Do_Action events to be shown in events.wordpress.org? Because we need that.

Just looking at this, and it's populated from a different database table wporg_events which isn't part of this codebase so we'll need to look at that separately.

Copy link
Contributor

@pkevan pkevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 think it will do as a hack, but we should monitor as to what doesn't flow through as a result of allowing the URLs.

@dorsvenabili
Copy link
Collaborator

Thank you, Paul! :)

we should monitor as to what doesn't flow through as a result of allowing the URLs

We'll monitor it and we'll report here any issues related to this new change.

Thanks!

Fix else if/elseif to avoid compile error.
remove whitespace
@pkevan
Copy link
Contributor

pkevan commented Aug 12, 2024

Luckily I tested and found the error in 1a51043

@devinmaeztri
Copy link
Member

Hello, Team! I tried to add the URL of Port Harcourt do_action and failed. Here is the notification that appears.
Screenshot 2024-08-13 at 15 20 58

https://central.wordcamp.org/wp-admin/post.php?post=6475854&action=edit

@devinmaeztri
Copy link
Member

I just noticed that the event status has been updated to Scheduled but URL is not saved.

Screenshot 2024-08-13 at 15 26 06

@devinmaeztri
Copy link
Member

I also found Port Harcourt do_action on Past WordCamps page. I looked on events.wordpress.org but it seems that past events are not available on the events page.

Screenshot 2024-08-13 at 15 27 17

@pkevan
Copy link
Contributor

pkevan commented Aug 13, 2024

Hello, Team! I tried to add the URL of Port Harcourt do_action and failed.

This is an open PR so no code changes have been made yet, so this is expected.

@pkevan
Copy link
Contributor

pkevan commented Aug 13, 2024

I also found Port Harcourt do_action on Past WordCamps page. I looked on events.wordpress.org but it seems that past events are not available on the events page.

Screenshot 2024-08-13 at 15 27 17

see: #1350 (comment)

@devinmaeztri
Copy link
Member

Noted! Thanks, Paul! I've update do_action Mumbai and it behaved similar to do_action Port Harcourt. I will update do_action Evanston and do_action Ahmedabad once the organizer completes the required fields.

@renintw renintw added [Component] WCPT WordCamp and meetup post types, applications, trackers, mentors [Priority] High [Type] Enhancement labels Aug 26, 2024
@renintw
Copy link
Contributor

renintw commented Aug 26, 2024

Tested locally and it looks good. A validation is added to we_host_it to fix the error prompt.

I'm wondering, will this fix allow Do_Action events to be shown in events.wordpress.org? Because we need that.

I'll work on this in a separate ticket.

@renintw renintw merged commit 6f5ef74 into production Aug 26, 2024
3 checks passed
@renintw renintw deleted the fix/1335-allow-doaction branch August 26, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] WCPT WordCamp and meetup post types, applications, trackers, mentors [Priority] High [Type] Enhancement
Projects
Status: ⛴️ Ready to ship
Development

Successfully merging this pull request may close these issues.

Allow status update of do_action application on WordCamp dashboard to "Scheduled"
5 participants