-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow doaction.org URLs for events #1350
Conversation
Thank you for fixing this issue, Dion! I'm wondering, will this fix allow Do_Action events to be shown in events.wordpress.org? Because we need that. Let me know and I'll open another issue if needed, thanks! :) |
Hi @dd32, any updates about if we can already add Do_Action URLs to the WordCamp CPT's sites field? |
Just looking at this, and it's populated from a different database table |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 think it will do as a hack, but we should monitor as to what doesn't flow through as a result of allowing the URLs.
Thank you, Paul! :)
We'll monitor it and we'll report here any issues related to this new change. Thanks! |
Fix else if/elseif to avoid compile error.
remove whitespace
Luckily I tested and found the error in 1a51043 |
Hello, Team! I tried to add the URL of Port Harcourt do_action and failed. Here is the notification that appears. https://central.wordcamp.org/wp-admin/post.php?post=6475854&action=edit |
I also found Port Harcourt do_action on Past WordCamps page. I looked on events.wordpress.org but it seems that past events are not available on the events page. |
This is an open PR so no code changes have been made yet, so this is expected. |
see: #1350 (comment) |
Noted! Thanks, Paul! I've update do_action Mumbai and it behaved similar to do_action Port Harcourt. I will update do_action Evanston and do_action Ahmedabad once the organizer completes the required fields. |
Tested locally and it looks good. A validation is added to
I'll work on this in a separate ticket. |
This PR (is untested) is intended to allow saving of
doaction.org
URL formats for Events.This is not an ideal PR, as it's hacky in nature, as the existing post type infrastructure really assumes that the only events are going to be ones hosted by the networks, and doesn't really fully support externally hosted sites for new sites.
This PR simply avoids some of the UI for such urls, and allows it to be saved.
I'm sure this could be more tightly integrated with a proper url validation and whatnot, but this might be enough until the question of "what to do with doaction.org" is resolved.
Fixes #1335
Props ,
Screenshots
How to test the changes in this Pull Request: